Yasmin - Media Ranker Project #95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ils to the gemfile
…me controller for the homepage and an accompanying index view file
…dels so that the schema file was updated
…e files to utilize the partial
…zed spelling mistake in the controller and movie index view page
… also private params to the book controller
…ten of everything utilizing the foundation block grid system
…n doing so, renamed ranking column in the schema
…m just trying to go to bed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wave 1: I believe all requirements were met...
Wave 2: My model tests are there, but my controller tests are lacking. I delayed submitting this project because even though I worked all weekend on it, I just couldn't get my Wave 1 requirements done in time. I didn't give myself enough opportunity to explore controller testing. Obviously, I want more practice with it, so I'm going to seek more opportunities to do controller testing in our next project (or come back to this one when I have time).
Wave 3: I utilized the Foundation grid to do some styling and I really like it as a tool. I definitely didn't give myself enough time to really explore the tool, so the styling is just hacked together. I couldn't get certain things, like my buttons, to display correctly. My buttons are a mess and I'm pretty sure I'm missing something when it comes to buttons and styling.
Overall, this is not the project I wanted to turn in, but this is what I've got right now.