Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Esther Ng JS Scrabble #18

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Esther Ng JS Scrabble #18

wants to merge 7 commits into from

Conversation

esther-ng
Copy link

I believe I have most basic functions working. I did notice I leaned toward keeping data in arrays rather than objects as I found it easier to maneuver. I find that when I tried to put data into an object format I ended up wanting to duplicate information into arrays in order to help iterate. I did ask a classmate how she approached it and she mentioned a 'for - in' loop that I would like to try to iterate through the properties of the object. I'm a little disappointed that I didn't figure out how to Google this before proceeding with the method I used.

I did end up separating out scrabble, player and tilebag because I couldn't figure out how to require all three in another file (test) when they were in a single file. I ended up writing my tests all in one file though I have a feeling this is not how it's supposed to go.

I utilized Istanbul to figure out coverage but haven't quite inspected the reports deeply -- seems pretty similar to simplecov.

I find the 'instance methods' not quite intuitive -- how would I utilize 'this' if I am not instantiating an instance by passing an argument / property? Would I need to set some arbitrary 'this' property? Would I be setting some default properties I want all instances to start with? ie. my Scrabble could be a function with no parameters but the same properties and functions it has now?

I haven't ever gotten to the create a board section on the Scrabble projects but think it might be important practice for something like a tic tac toe whiteboarding exercise (nested arrays?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants