Jeannie -trek #18
Open
Jeannie -trek #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Dec 1, 2016
There was a problem hiding this comment.
@BJHunnicutt Not bad, you need to do some more work detecting failures, but overall it meets the expectations.
Its just so GREEEEN.
| console.log('Failure.'); | ||
| }).always(function() { | ||
| $('#test-message').text('Something Happened!'); | ||
| }); |
There was a problem hiding this comment.
The user here isn't being told if the request fails, something's wrong here.
| if (!$('#trips').is(e.target) && !popup.is(e.target) && popup.has(e.target).length === 0) { | ||
| popup.hide(200); | ||
| } | ||
| }); |
| // Print out a list of response links | ||
| var successCallback = function (response) { | ||
| $('#trips').show(); | ||
|
|
There was a problem hiding this comment.
I would show the div after you load it with HTML. Otherwise you'll see if flash with content.
| console.log(postUrl); | ||
|
|
||
| alert('Thank you! Your reservation has been submitted!'); | ||
| $.post(postUrl, formData, callback); //With this version you can get rid of the ids on the form |
There was a problem hiding this comment.
What about when the post encounters an error?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.