forked from AdaGold/trek
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Griego PR for Trek #36
Open
Trishthedish
wants to merge
12
commits into
Ada-C6:master
Choose a base branch
from
Trishthedish:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e trips when button is clicked.
…clear, minimal distinctions in category.
…to get rid of excess css
…fo. Its coming out blank. Which means I'm not grabbing my form data properly. But I'm not sure how else to do it.
…form. Also, placed it in the wrong the place. It should have been on input not section.
Wave3 trish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimum Requirements
Click button or link to show all trips ✅
Can click on a trip, from the list of trips, to see more information about that trip ✅
Should be able to see id, name, destination, continent, about, category, weeks and cost✅
While viewing a single trip, you can reserve a spot ✅
Use a form to submit your name to reserve a spot on the trip you are viewing ✅
Lessons Learned
idsname= (see above) on my html<section>
tags. Lesson learned, placing naming conventions in the proper place. In this case on my<input>
tags!command + shift + j > network > click on the file you wish to inspect > preview > so much to see!
Found this article extremely helpful: https://developers.google.com/web/tools/chrome-devtools/network-performance/resource-loading for debugging@PilgrimMemoirs @CheezItMan