Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Remove unused module-for-acceptance file #1155

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

bantic
Copy link
Contributor

@bantic bantic commented Dec 27, 2024

Trivial change: remove this unused file.

I noticed that it was unused when experimenting locally w/ an embroider build. Embroider correctly complained that it couldn't resolve the ../start-app import.

When I looked closer, I saw that nothing uses this file. It looks like it was never used, in fact, because git log -S module-for-acceptance and git log -S moduleForAcceptance both find nothing.

@bantic bantic requested a review from a team December 27, 2024 11:47
@mixonic mixonic merged commit b2d6bbc into master Jan 2, 2025
8 checks passed
@mixonic mixonic deleted the bantic/remove-unused-m-f-a-file branch January 2, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants