Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop adde-lint, use eslint directly for "lint:js" run-script #1163

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

bantic
Copy link
Contributor

@bantic bantic commented Feb 5, 2025

For the "lint:js" run script, drop the usage of the custom @addepar/ember-toolbox-supplied ember adde-lint command, replacing it with direct usage of eslint instead.

Technically speaking, this is broader lint coverage than we had before.
The adde-lint command (as in ember adde-lint) is defined at Addepar/addepar-ember-toolbox@897b838/index.js#L29-L44
For --javascript, the lint subcommand code concats the STANDARD_APP_FILES and STANDARD_APP_PATHS (defined here) and then filters out any that don't exist. It passes those as explicit args to the eslint command.

It seems more future-safe to lint using the catchall ..
In order to make linting work correctly I had to add dist/ to the .eslintignore file.
I used DEBUG=eslint:cli-engine npx eslint . (from stackoverflow, here: https://stackoverflow.com/questions/70284958/how-to-list-files-being-linted-by-eslint) to double-check which files are linted.

@bantic bantic requested a review from a team February 5, 2025 15:17
@bantic bantic merged commit 34b2951 into master Feb 5, 2025
9 checks passed
@bantic bantic deleted the bantic/webcore-3168 branch February 5, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants