-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: remove DD metrics reporting from CI #10930
base: master
Are you sure you want to change the base?
Conversation
Deploying agoric-sdk with
|
Latest commit: |
a7be9a1
|
Status: | ✅ Deploy successful! |
Preview URL: | https://15cb4b5d.agoric-sdk.pages.dev |
Branch Preview URL: | https://mk-dd-removal.agoric-sdk.pages.dev |
@mujahidkay Do have any engineering issue for it as DD sunset follow-up? Also do you think if it is doable as quick-win then we can sync and work on sending the stats first before stopping the DD reporting. @frazarshad Thoughts? |
@Muneeb147 I'm not certain how quick of a win would those be. I'm in favor of benching this PR altogether till we port those metrics to GCP (no harm done AFAIK as our contract runs till September) and hopefully we can get this done in a sprint. |
Apparently, our contract with DD run till September. Pending confirmation, this PR will remain draft. Integration test and benchmark results DO NOT get reported GCP right now. Ideally, we should only merge this when we handle these two but not a hard requirement IMO.
closes: ticket
Description
Removes all Datadog related integration for reporting test metrics. Also removes additional helper scripts. In its current state, we are also disabling reporting for vaults stress benchmark and test-docker-build integration test result (have created separated tickets for them under SRE). Post merge, we can remove DD secrets from this repo.
Security Considerations
None
Scaling Considerations
None
Documentation Considerations
Its CI only so None
Testing Considerations
all CI. Like mentioned in the description, in its current state, we will miss out on benchmark and integration test result metrics because our existing gcp CI reporting script doesn't handle these two cases.
Upgrade Considerations
None