feat(SwingSet): Report vat snapshot size delta on save #10935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson042
approved these changes
Feb 4, 2025
packages/SwingSet/src/kernel/vat-loader/manager-subprocess-xsnap.js
Outdated
Show resolved
Hide resolved
packages/SwingSet/src/kernel/vat-loader/manager-subprocess-xsnap.js
Outdated
Show resolved
Hide resolved
Deploying agoric-sdk with
|
| Latest commit: |
60eab22
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://068dfe19.agoric-sdk.pages.dev |
| Branch Preview URL: | https://sliakh-10910-report-heap-sna.agoric-sdk.pages.dev |
mhofman
requested changes
Feb 6, 2025
There was a problem hiding this comment.
I love that we're moving the heap snapshot slogging in a single place.
I think that if restartWorker is true, the delta will currently remain null (or stale) because we're never updating it with the size of the snapshot taken.
Also I guess the delta metric got stuck in the keyboard since it's not reported in the slog event ;)
packages/SwingSet/src/kernel/vat-loader/manager-subprocess-xsnap.js
Outdated
Show resolved
Hide resolved
Two changes: 1. move slog 'heap-snapshot-save' from vatKeeper.js to manager-subprocess-xsnap.js 2. track uncompressedSizeLoaded in a local variable inside createFromBundle() and report delta from makeSnapshot()
Co-authored-by: Richard Gibson <[email protected]>
Co-authored-by: Mathieu Hofman <[email protected]>
move uncompressedSizeLoaded into saveSnapshot().
siarhei-agoric
force-pushed
the
sliakh-10910-report-heap-snapshot-size-delta
branch
from
f493ed3 to
60eab22
Compare
mhofman
requested changes
Feb 8, 2025
| const results = await snapStore.saveSnapshot( | ||
| vatID, | ||
| snapPos, | ||
| snapshotStream, |
There was a problem hiding this comment.
I totally missed that here. We cannot use snapshotStream here but must use a stream provided as argument, which in the case of restartWorker would be snapStoreSaveStream, a tee of the original snapshotStream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #10910
Description
Security Considerations
none
Scaling Considerations
none
Documentation Considerations
heap-snapshot-saveslog entry now has a newuncompressedSizeDeltaproperty representing the change in snapshot size in bytes at snapshot save time if a vat had been loaded from a snapshot.uncompressedSizeDeltais null if a vat had been started from a bundle without snapshot loaded.Testing Considerations
Need to confirm that:
uncompressedSizeDeltais present in allheap-snapshot-saveslog entriesUpgrade Considerations
None.