feat(xsnap): Support legacy and latest variants #11031
Draft
+147
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
force-pushed
the
kriskowal-xsnap-variants-11030
branch
from
6e97796 to
e5f7b5c
Compare
Deploying agoric-sdk with
|
| Latest commit: |
e5f7b5c
|
| Status: | ⚡️ Build in progress... |
kriskowal
force-pushed
the
kriskowal-xsnap-variants-11030
branch
from
e5f7b5c to
fc9f5df
Compare
Deploying agoric-sdk with
|
| Latest commit: |
fc9f5df
|
| Status: | ⚡️ Build in progress... |
Deploying agoric-sdk with
|
| Latest commit: |
e5f7b5c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ce4f5319.agoric-sdk.pages.dev |
| Branch Preview URL: | https://kriskowal-xsnap-variants-110.agoric-sdk.pages.dev |
kriskowal
force-pushed
the
kriskowal-xsnap-variants-11030
branch
from
fc9f5df to
7335125
Compare
Deploying agoric-sdk with
|
| Latest commit: |
7335125
|
| Status: | ⚡️ Build in progress... |
Deploying agoric-sdk with
|
| Latest commit: |
fc9f5df
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f890e92c.agoric-sdk.pages.dev |
| Branch Preview URL: | https://kriskowal-xsnap-variants-110.agoric-sdk.pages.dev |
Deploying agoric-sdk with
|
| Latest commit: |
7335125
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3725eb7f.agoric-sdk.pages.dev |
| Branch Preview URL: | https://kriskowal-xsnap-variants-110.agoric-sdk.pages.dev |
kriskowal
force-pushed
the
kriskowal-xsnap-variants-11030
branch
from
7335125 to
075f974
Compare
Deploying agoric-sdk with
|
| Latest commit: |
075f974
|
| Status: | ⚡️ Build in progress... |
Deploying agoric-sdk with
|
| Latest commit: |
075f974
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9ed5818e.agoric-sdk.pages.dev |
| Branch Preview URL: | https://kriskowal-xsnap-variants-110.agoric-sdk.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #11030
Refs: #10905
Description
This change adds a
variantoption to thexsnapconstructor that multiplexes"legacy"and"latest"version trains of the underlyingxsnap-worker, such that existing usage continues to use snapshot-compatible"legacy"versions and upgradable and restartable workers can use"latest"for new features that will cause divergent behavior and incompatible snapshot formats.Security Considerations
Requires further consideration.
Scaling Considerations
This change doubles the number of binaries
xsnapproduces. I’ve included a compensating change that usesmake -jwith the number of available CPUs on the installation target. This change could be brought forward since it is orthogonal.Documentation Considerations
Includes an explanation of the new feature and the intended compatibility concerns in
README.md.Testing Considerations
"latest"and verify its absence in"legacy"Upgrade Considerations
This change preserves the status quo for all extant vats, but invites future changes to the SwingSet to enable new vats to electively move to the
"latest"train. This implies different treatment for a chain software upgrade that can include an incompatible version ofxsnap(to be assumed by default). It also implies further work to automatically promote vats (virtual workers) from"legacy"to"latest"if they successfully upgrade.