fix panic during create integration tables when API_LISTEN doesn't …

…contain ":" character, fix #790
Altinity · Nov 23, 2023 · b363d94 · b363d94
1 parent c4b155a
commit b363d94
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/ChangeLog.md b/ChangeLog.md
@@ -1,11 +1,12 @@
-# v2.5.0 (not released yet)
+# v2.4.6
 IMPROVEMENTS
 - make 'kopia' custom scripts really increment fix [781](https://github.com/Altinity/clickhouse-backup/issues/781) 
 - add `force_http` and improve retries in GCS upload [784](https://github.com/Altinity/clickhouse-backup/pull/784), thanks @minguyen9988
 
 BUG FIXES
 - add `Array(Tuple())` to exclude list for `check_parts_columns:true' fix [789](https://github.com/Altinity/clickhouse-backup/issues/789)
 - fix `delete remote` command for s3 buckets with enabled versioning fix [782](https://github.com/Altinity/clickhouse-backup/issues/782)
+- fix panic during create integration tables when `API_LISTEN` doesn't contain ":" character, fix [790](https://github.com/Altinity/clickhouse-backup/issues/790)
 
 # v2.4.5
 BUG FIXES

diff --git a/pkg/server/server.go b/pkg/server/server.go
@@ -1494,7 +1494,10 @@ func (api *APIServer) CreateIntegrationTables() error {
 		return fmt.Errorf("can't connect to clickhouse: %w", err)
 	}
 	defer ch.Close()
-	port := strings.Split(api.config.API.ListenAddr, ":")[1]
+	port := "80"
+	if strings.Contains(api.config.API.ListenAddr, ":") {
+		port = api.config.API.ListenAddr[strings.Index(api.config.API.ListenAddr, ":"):]
+	}
 	auth := ""
 	if api.config.API.Username != "" || api.config.API.Password != "" {
 		params := url.Values{}