Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match hovercards style with latest design changes #137

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

jcheringer
Copy link
Contributor

@jcheringer jcheringer commented Nov 26, 2024

This PR adjusts the hovercards to match the latest design changes.
Here are some examples shared by our designer, Andrei (@Luchadores):

image

Andrei also asked us to remove the verified icon from all variations of the hovercards.

hovercard

Testing Instructions

  • Check out this PR and test it through the playground
  • Check if the designs match what was shared by Andrei

@jcheringer jcheringer requested a review from wellyshen November 26, 2024 14:37
@jcheringer jcheringer self-assigned this Nov 26, 2024
Copy link

Size Change: -149 B (-0.37%)

Total Size: 40.2 kB

Filename Size Change
dist/index.esm.js 8.74 kB -28 B (-0.32%)
dist/index.js 8.88 kB -29 B (-0.33%)
dist/index.react.js 10.9 kB -30 B (-0.27%)
dist/index.react.umd.js 6.33 kB -31 B (-0.49%)
dist/index.umd.js 5.4 kB -31 B (-0.57%)

compressed-size-action

Copy link
Contributor

@wellyshen wellyshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jcheringer jcheringer merged commit 792c207 into trunk Nov 27, 2024
2 checks passed
@jcheringer jcheringer deleted the update/hovercards-minor-styles branch November 27, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants