Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat(slider): add fluent ui range slider #211

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

scharinger
Copy link
Contributor

Describe your changes

Adding a new type of slider, RangeSlider, to next to Slider. It's directly imported from Fluent UI but uses a theme that is derived from the current theme provided by the practical theme context..

MicrosoftTeams-image

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@scharinger scharinger force-pushed the range-slider-fluentui branch from b74e0e1 to 71cccf9 Compare March 16, 2022 18:35
@scharinger
Copy link
Contributor Author

Is it needed to style it more to make it look and behave more like practical? If so, does someone have any suggestions on how to do this with fluent ui components?

@scharinger scharinger force-pushed the range-slider-fluentui branch 2 times, most recently from 8cdd6aa to dcf1550 Compare March 21, 2022 16:01
@scharinger scharinger force-pushed the range-slider-fluentui branch from dcf1550 to e23f0b2 Compare March 21, 2022 16:02
@Tigge Tigge self-requested a review as a code owner October 17, 2022 13:32
@Tigge Tigge force-pushed the main branch 7 times, most recently from 92874f3 to 4adee08 Compare October 18, 2022 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant