Fix issue of copy succeeded without 'r' permission in SAS token credential #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmaZhu
force-pushed
the
copy_auth
branch
2 times, most recently
from
ae79fc3 to
c28e46d
Compare
blueww
reviewed
Dec 26, 2023
| @@ -664,7 +662,8 @@ export default class BlobHandler extends BaseHandler implements IBlobHandler { | |||
| throw StorageErrorFactory.getBlobNotFound(context.contextId!); | |||
| } | |||
|
|
|||
| if (sourceAccount !== blobCtx.account) { | |||
| const sig = url.searchParams.get("sig"); | |||
| if ((sourceAccount !== blobCtx.account) || (sig !== null)) { | |||
There was a problem hiding this comment.
Just to confirm, this is the only product by propose.
There are so many coding format changes, and not easy to get all real product code change.
There was a problem hiding this comment.
Yes, this is the only place I changed for product code. Other are all changed by prettier tool .
blueww
approved these changes
Dec 26, 2023
|
@EmmaZhu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contribution! Please go through following checklist before sending PR.
PR Branch Destination
mainbranch.legacy-devbranch.Always Add Test Cases
Make sure test cases are added to cover the code change.
Add Change Log
Add change log for the code change in
Upcoming Releasesection inChangeLog.md.Development Guideline
Please go to CONTRIBUTION.md for steps about setting up development environment and recommended Visual Studio Code extensions.