Fail the insert entity request with double property whose value is greater than MAX_VALUE (Issue #2387) #2388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eater than MAX_VALUE (Issue Azure#2387)
EmmaZhu
reviewed
Apr 12, 2024
| @@ -12,6 +12,10 @@ export class EdmDouble implements IEdmType { | |||
| // TODO: Support convert from string. parseFloat doesn't strictly checks non number chars | |||
| const val = Number.parseFloat(value); | |||
| if (!Number.isNaN(val)) { | |||
| if (val === Number.POSITIVE_INFINITY || val === Number.NEGATIVE_INFINITY) | |||
There was a problem hiding this comment.
Add a comment about the infinity you have tested as a history reference.
EmmaZhu
approved these changes
Apr 12, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix : #2387
Thanks for contribution! Please go through following checklist before sending PR.
PR Branch Destination
mainbranch.legacy-devbranch.Always Add Test Cases
Make sure test cases are added to cover the code change.
Add Change Log
Add change log for the code change in
Upcoming Releasesection inChangeLog.md.Development Guideline
Please go to CONTRIBUTION.md for steps about setting up development environment and recommended Visual Studio Code extensions.