Merge pull request #17 from veena-udayabhanu/master

Storage Client Library - 0.3.2
Azure · Jul 26, 2014 · e68bc07 · e68bc07
2 parents 8a624c1 + 6cb0618
commit e68bc07
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 12 deletions.
diff --git a/ChangeLog.txt b/ChangeLog.txt
@@ -1,10 +1,18 @@
 Note: This is an Azure Storage only package. The all up Azure node sdk still has the old storage bits in there. In a future release, those storage bits will be removed and an npm dependency to this storage node sdk will 
 be taken. This is a CTP v1 release and the changes described below indicate the changes from the Azure node SDK 0.9.8 available here - https://github.com/Azure/azure-sdk-for-node.
 
+2014.07.25 Version 0.3.2
+
+ALL
+* Fixed an issue which prevented transient server errors like ECONNRESET, ESOCKETTIMEDOUT and ETIMEDOUT from being retried.
+
+BLOB
+* Fixed an issue which caused a reference error in blobs due to 'err' not being defined.
+
 2014.07.22 Version 0.3.1
 
 ALL
-* Fixed a bug which failed to validate special names for containers and tables.
+* Fixed an issue which failed to validate special names for containers and tables.
 * Exposed the Validation utility methods so users can use it to validate resource names.
 
 BLOB
@@ -13,18 +21,18 @@ BLOB
 2014.07.07 Version 0.3.0
 
 BLOB
-* Fixed a bug which failed to return single item blocklists while doing listBlocks.
+* Fixed an issue which failed to return single item blocklists while doing listBlocks.
 
 FILE
 * Added File Service support. The File Service and the associated APIs are in preview.
 
 2014.07.01 Version 0.2.1
 
 ALL
-* Fixed a bug with casing which caused the module to fail on linux machines.
+* Fixed an issue with casing which caused the module to fail on linux machines.
 
 BLOB
-* Fixed a bug which failed to upload an empty blob for empty block blob files uploaded using createBlockBlobFromFile when retry policies were used.
+* Fixed an issue which failed to upload an empty blob for empty block blob files uploaded using createBlockBlobFromFile when retry policies were used.
 
 2014.06.16 Version 0.2.0
 

diff --git a/lib/common/filters/retrypolicyfilter.js b/lib/common/filters/retrypolicyfilter.js
@@ -126,7 +126,7 @@ RetryPolicyFilter._handle = function (self, requestOptions, next) {
         // the request.
         if (returnObject.error && azureutil.objectIsNull(returnObject.retryable) &&
             ((!azureutil.objectIsNull(returnObject.response) &&
-            retryInfo.retryable) || (returnObject.error.message === 'ETIMEDOUT' || returnObject.error.message === 'ESOCKETTIMEDOUT' || returnObject.error.message === 'ECONNRESET'))) {
+            retryInfo.retryable) || (returnObject.error.code === 'ETIMEDOUT' || returnObject.error.code === 'ESOCKETTIMEDOUT' || returnObject.error.code === 'ECONNRESET'))) {
 
           if (retryRequestOptions.currentLocation === Constants.StorageLocation.PRIMARY) {
             lastPrimaryAttempt = returnObject.operationEndTime;

diff --git a/lib/common/util/constants.js b/lib/common/util/constants.js
@@ -31,7 +31,7 @@ var Constants = {
   /*
   * Specifies the value to use for UserAgent header.
   */
-  USER_AGENT_PRODUCT_VERSION: '0.3.1',
+  USER_AGENT_PRODUCT_VERSION: '0.3.2',
 
   /**
   * The number of default concurrent requests for parallel operation.

diff --git a/lib/services/blob/blobservice.js b/lib/services/blob/blobservice.js
@@ -2460,7 +2460,7 @@ BlobService.prototype.createWriteStreamToExistingPageBlob = function (container,
     }
 
     if (callback) {
-      callback(err, blob, response);
+      callback(error, blob, response);
     }
   });
 
@@ -3106,7 +3106,7 @@ BlobService.prototype.createWriteStreamToBlockBlob = function (container, blob,
     }
 
     if (callback) {
-      callback(err, blob, response);
+      callback(error, blob, response);
     }
   });
 

diff --git a/lib/services/file/fileservice.js b/lib/services/file/fileservice.js
@@ -2274,7 +2274,7 @@ FileService.prototype.createWriteStreamToExistingFile = function (share, directo
     }
 
     if (callback) {
-      callback(err, file, response);
+      callback(error, file, response);
     }
   });
 
@@ -2340,13 +2340,13 @@ FileService.prototype.createWriteStreamToNewFile = function (share, directory, f
     }
     else {
       stream.resume();
-      self._createFileFromChunkStream(share, directory, file, stream, null, options, function (err, file, response) {
+      self._createFileFromChunkStream(share, directory, file, stream, null, options, function (error, file, response) {
         if(error) {
           stream.emit('error', error);
         }
 
         if (callback) {
-          callback(err, file, response);
+          callback(error, file, response);
         }
       });
     }

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "azure-storage",
   "author": "Microsoft Corporation",
-  "version": "0.3.1",
+  "version": "0.3.2",
   "description": "Microsoft Azure Storage Client Library for Node.js",
   "tags": [
     "azure",