[ci] upload snap to snapstore #6073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,6 +64,16 @@ jobs: | |||
| run: | | |||
| echo "VCPKG_BINARY_SOURCES=clear;x-aws-config,no-sign-request;x-aws,s3://vcpkg.cache.boinc/,read" >> $GITHUB_ENV | |||
|
|
|||
| - name: Fix version in the snapcraft.yaml | |||
| run: | | |||
| PKG_VERSION=$(cat version.h | grep BOINC_VERSION_STRING | sed -e 's|#define BOINC_VERSION_STRING||' | jq -r .) | |||
There was a problem hiding this comment.
The use of 'jq' here is incorrect as it is typically used for JSON parsing. It should be removed from the command.
Suggested change
| PKG_VERSION=$(cat version.h | grep BOINC_VERSION_STRING | sed -e 's|#define BOINC_VERSION_STRING||' | jq -r .) | |
| PKG_VERSION=$(cat version.h | grep BOINC_VERSION_STRING | sed -e 's|#define BOINC_VERSION_STRING||' | tr -d '[:space:]') |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
2 tasks
AenBleidd
force-pushed
the
vko_upload_snap
branch
2 times, most recently
from
e92b718 to
f3933ac
Compare
Signed-off-by: Vitalii Koshura <[email protected]>
AenBleidd
force-pushed
the
vko_upload_snap
branch
from
f3933ac to
01dbf90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.