Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement conditioning on Host_Age and Host_Age_Months module build-schema #392

Merged
merged 10 commits into from
Feb 13, 2025

Conversation

Aberdur
Copy link
Contributor

@Aberdur Aberdur commented Feb 12, 2025

No description provided.

@Daniel-VM
Copy link
Member

I think it would be more suitable to adopt a more flexible and generic approach, such as using configuration files and specialized functions in assets (or json schema utilities) to handle this conditioning according to project needs. Otherwise, we may end up relying on ad hoc or non-specialized modules.

@Aberdur Aberdur marked this pull request as draft February 13, 2025 07:15
@Aberdur Aberdur marked this pull request as ready for review February 13, 2025 09:13
@Aberdur Aberdur changed the title Implemente conditioning on Host_Age and Host_Age_Months module build-schema Implement conditioning on Host_Age and Host_Age_Months module build-schema Feb 13, 2025
Copy link
Member

@Daniel-VM Daniel-VM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aberdur Aberdur merged commit 636511b into BU-ISCIII:develop Feb 13, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants