Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FrameGraph: add support for highlight layer #16086

Merged
merged 19 commits into from
Jan 20, 2025
Merged

FrameGraph: add support for highlight layer #16086

merged 19 commits into from
Jan 20, 2025

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Jan 18, 2025

No description provided.

Popov72 added 18 commits January 9, 2025 17:29
@Popov72
Factor post process code + add pass post process
7440d8d
@Popov72
Fix wgsl shaders
8ffac32
@Popov72
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js into…
e9b85f1 
… framegraph-highlight-layer
@Popov72
Reuse code
7a44591
@Popov72
Fix _depthStencilTextureWithStencil not correctly updated
4558447
@Popov72
Add missing properties to glow layer block
833e404
@Popov72
Add an objectRenderer output to the object renderer block
e0b83fa
@Popov72
Add support for the "object" connection point type to node render graphs
fbb25dd
@Popov72
Make task dependencies a Set
200c581
@Popov72
Add a pass to be disabled
1832a8f
@Popov72
Fix setting sampling mode of textures at the wrong time in WebGL
147b4d7
@Popov72
Improve error handling of FrameGraph.whenReadyAsync
a804f3a
@Popov72
Fix extraInitializationsAsync not being taken into account when passe…
e2bd890 
…d through the options parameter
@Popov72
Add save and restore depth/stencil state functions to the frame graph…
3eb4cee 
… render context
@Popov72
Add support for the highlight layer to the frame graph and NRGE
0598fc9
@Popov72
Fix visu test
3568671
@Popov72
Refactor HighlightLayer to use ThinHighlightLayer
44c0fd1
@Popov72
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js into…
940748f 
… framegraph-highlight-layer
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 18, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 18, 2025

You have made possible changes to one or more graph tools. To test the snapshots:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16086/merge/nodeEditor/
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16086/merge/nodeGeometryEditor/
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16086/merge/nodeRenderGraphEditor/
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16086/merge/guiEditor/

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 18, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 18, 2025

You have made possible changes to one or more graph tools. To test the snapshots:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16086/merge/nodeEditor/
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16086/merge/nodeGeometryEditor/
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16086/merge/nodeRenderGraphEditor/
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16086/merge/guiEditor/

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 18, 2025

Snapshot stored with reference name:
refs/pull/16086/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16086/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16086/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/16086/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/16086/merge
https://gui.babylonjs.com/?snapshot=refs/pull/16086/merge
https://nme.babylonjs.com/?snapshot=refs/pull/16086/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/16086/merge#BCU1XR#0

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 18, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16086/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 18, 2025

Visualization tests for WebGPU (Experimental)

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16086/merge/testResults/webgpuplaywright/index.html

sebavan
sebavan reviewed Jan 20, 2025
View reviewed changes
Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just 2 tiny points

packages/dev/core/src/Engines/Extensions/engine.renderTarget.ts Show resolved Hide resolved
packages/dev/core/src/Rendering/objectRenderer.ts Show resolved Hide resolved
@sebavan sebavan merged commit 56b628a into BabylonJS:master Jan 20, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebavan sebavan sebavan approved these changes

Assignees
No one assigned
Labels
enhancement frame graph
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Popov72 @bjsplat @sebavan