Sending a pull request.

[mustah]

Hi Bas.

I've made some changes to this amazing plugin:

1. Bug fix, where in intellij idea version 11.1.1 and 11.1.2 made the selection move down 2 steps in stead of one when pressing CMD+E.
2. Some code clean ups.
3. Created possibility to display a list of modified files in the default change list of the selected VCS. (I've personally mapped it to CTRL+E)

Please review the code and come back to me :-)

Thx and kind regards,
/Must

[BasLeijdekkers]

Hi Must,

Thanks for the pull request. I noticed you have managed to update the
plugin in the repository too. Sorry for the late reply by the way, but
I guess you're managing things without my help:-)

Shall I add you to the committers of my TabSwitch repository?

Thanks,
Bas

On Sun, Jun 3, 2012 at 10:24 PM, Must
[email protected]
wrote:

Hi Bas.

I've made some changes to this amazing plugin:

1. Bug fix, where in intellij idea version 11.1.1 and 11.1.2 made the selection move down 2 steps in stead of one when pressing CMD+E.
2. Some code clean ups.
3. Created possibility to display a list of modified files in the default change list of the selected VCS.

Please review the code and come back to me :-)

Thx and kind regards,
/Must

You can merge this Pull Request by running:

 git pull https://github.com/mustah/TabSwitch master

Or you can view, comment on it, or merge it online at:

 #2

-- Commit Summary --

• code reformatting
• Added override annotation
• TabSwitch version 3. Includes an additional popup chooser window, where the changes from default change list of your VCS is listed.
• Added intellij idea project files too.
• TabSwitch.iws is not needed in the repository.

-- File Changes --

M META-INF/plugin.xml (41)
A TabSwitch.iml (15)
A TabSwitch.ipr (321)
M build.xml (33)
A src/org/intellij/ideaplugins/tabswitch/ComponentFactory.java (58)
D src/org/intellij/ideaplugins/tabswitch/Handler.java (291)
A src/org/intellij/ideaplugins/tabswitch/ListCellRendererFactory.java (66)
A src/org/intellij/ideaplugins/tabswitch/ListSelectionListenerFactory.java (60)
D src/org/intellij/ideaplugins/tabswitch/PreviousTabAction.java (24)
D src/org/intellij/ideaplugins/tabswitch/SwitchTabAction.java (58)
D src/org/intellij/ideaplugins/tabswitch/TabAction.java (47)
A src/org/intellij/ideaplugins/tabswitch/TabSwitchProjectComponent.java (213)
M src/org/intellij/ideaplugins/tabswitch/TabSwitchSettings.java (69)
R src/org/intellij/ideaplugins/tabswitch/action/NextTabAction.java (23)
A src/org/intellij/ideaplugins/tabswitch/action/NextVcsChangeAction.java (28)
A src/org/intellij/ideaplugins/tabswitch/action/SwitchTabAction.java (57)
A src/org/intellij/ideaplugins/tabswitch/action/TabAction.java (60)
A src/org/intellij/ideaplugins/tabswitch/filefetchers/FileFetcher.java (23)
A src/org/intellij/ideaplugins/tabswitch/filefetchers/FileFetcherChangedFilesInVcs.java (66)
A src/org/intellij/ideaplugins/tabswitch/filefetchers/FileFetcherOpenTabFiles.java (34)

-- Patch Links --

 https://github.com/BasLeijdekkers/TabSwitch/pull/2.patch
 https://github.com/BasLeijdekkers/TabSwitch/pull/2.diff

---

Reply to this email directly or view it on GitHub:
#2

Bas Leijdekkers | Desert Island BV | T +31 6 2202 8877 | E
[email protected]

[mustah]

Hi Bas.

Yes, please do.

Thx,
/Must

[mustah]

Hi Bas. Do you want to merge my forked version with yours?

And maybe update the plugin on your account. Because there are two TabSwitch plugins now available. I can remove mine (http://plugins.intellij.net/plugin/index?pr=idea&pluginId=7062).

You can find the lastest version here: https://github.com/mustah/TabSwitch/blob/master/TabSwitch.jar

Thx,
/Must