Add strong naming, public properties, and support for .NET 8 and .NET 9 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r classes - Added strong naming to ensure the assembly is signed. - Exposed the 'Diameter' property in DstvHole. - Exposed 'PointList' and 'Type' properties in Contour
Added .NET 8 as a target framework to support the latest .NET version.
ilCosmico
changed the title
|
Hi, I was wondering if there are any updates regarding this pull request or any chance these changes might be merged soon? Thanks in advance! |
|
@martijn00, any chance these changes might be merged? Thanks in advance! |
martijn00
requested changes
Feb 6, 2025
… .NET 8+, and added .NET 9 target. - Fixed incorrect path in AssemblyOriginatorKeyFile for the test project. - Resolved various compilation issues affecting .NET 8 and newer versions. - Added support for .NET 9 compilation.
ilCosmico
changed the title
- Added .NET 8 and 9 to GitHub Actions workflow. - Fixed build failure due to missing .NET 8 SDK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes the following updates:
Strong Naming:
Public Properties:
Diameterproperty in theDstvHoleclass, allowing access to the hole diameter.PointListandTypeproperties in theContourclass with improved immutability by returningIReadOnlyList<DstvContourPoint>for safer access to the points..NET 8 Target:
.NET 8as a target framework to ensure compatibility with the latest .NET version and to take advantage of its new features and improvements.These changes aim to improve security, accessibility, and future compatibility with .NET 8. Please review the updates and merge if everything looks good. Thank you!