Null check #1669
Merged
Null check #1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 058b1a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 058b1a7.
☁️ Nx Cloud last updated this comment at |
Deploying mitosis with
|
| Latest commit: |
058b1a7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://327340d4.mitosis-9uh.pages.dev |
| Branch Preview URL: | https://korey-null-check.mitosis-9uh.pages.dev |
samijaber
approved these changes
Jan 27, 2025
| if (typeof linkUrl === 'object' && linkUrl['@type'] === '@builder.io/core:LocalizedValue') { | ||
| if ( | ||
| typeof linkUrl === 'object' && | ||
| linkUrl !== null && |
There was a problem hiding this comment.
Weird that we need this since there's a if (linkUrl) right above?
There was a problem hiding this comment.
This particular null check might not be 100% necessary, but I wanted to keep it consistent with the other spots where we check for localized values
Co-authored-by: Sami Jaber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds null check for property values
https://www.loom.com/share/be7a4cd800614433aaa82b7675b87bd8
https://builder-io.atlassian.net/browse/ENG-8150
yarn fmt:prettier.yarn test:updateyarn g:changesetand follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.