This repository has been archived by the owner on Dec 22, 2023. It is now read-only.
Extending status command for multiple spaces #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis fix no one likes bare excepts - hope someone like this except
izzy
reviewed
Dec 27, 2017
| if resp.status != 200: | ||
| if target is not None: | ||
| bot.privmsg(target, msg) | ||
| raise Exception() |
There was a problem hiding this comment.
This ideally should throw a custom exception, not a generic one
There was a problem hiding this comment.
Well it is a good idea. You can add this.
izzy
reviewed
Dec 27, 2017
| @@ -202,8 +202,8 @@ def _get_talk(bot, hall, slot=0): | |||
|
|
|||
| try: | |||
| json_data = _get_json_data(bot) | |||
| except: | |||
| """Silently ignore errors""" | |||
| except Exception as e: | |||
There was a problem hiding this comment.
And this should catch only this custom exception
There was a problem hiding this comment.
Well it is a good idea. You can add this. But this is a PR for station-plugin, not cccongress.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.