Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: boards: add support for the candlelightFD board #60

Merged

Conversation

henrikbrixandersen
Copy link
Member

Add support for the candlelightFD board from Linux Automation.

The board optionally supports a second CAN channel, but only provides two LEDs (RX/TX) in total. To work around this limitation, the "dual" configuration uses the RX LED for channel 0 state/activity, and the TX LED for channel 1 state/activity.

Since this board has no activity LEDs in its dual configuration, add a small change to the LED initialisation code to support this.

@henrikbrixandersen
Copy link
Member Author

The build failures are resolved in zephyrproject-rtos/zephyr#83410

@henrikbrixandersen henrikbrixandersen force-pushed the candlelightfd branch 3 times, most recently from 5bf7e6f to 8ac08f9 Compare January 1, 2025 18:17
@henrikbrixandersen henrikbrixandersen marked this pull request as ready for review January 1, 2025 18:27
Support CANnectivity devicetree channels without activity LEDs.

Signed-off-by: Henrik Brix Andersen <[email protected]>
@sknsean
Copy link

sknsean commented Jan 14, 2025

Tested OK 👍

Add support for the candlelightFD board from Linux Automation.

The board optionally supports a second CAN channel, but only provides two
LEDs (RX/TX) in total. To work around this limitation, the "dual"
configuration uses the RX LED for channel 0 state/activity, and the TX LED
for channel 1 state/activity.

Signed-off-by: Henrik Brix Andersen <[email protected]>
Tested-by: Sean Nyekjaer <[email protected]>
@henrikbrixandersen henrikbrixandersen merged commit fa6ef80 into CANnectivity:main Jan 14, 2025
6 checks passed
@henrikbrixandersen
Copy link
Member Author

Tested OK 👍

Thanks!

@henrikbrixandersen henrikbrixandersen deleted the candlelightfd branch January 15, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants