Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSD support #94

Merged
merged 18 commits into from
Aug 2, 2024
Merged

BSD support #94

merged 18 commits into from
Aug 2, 2024

Conversation

sedmicha
Copy link
Collaborator

Modifications to make ipfixcol2 buildable on BSD systems (tested on FreeBSD 15)

Building with Clang is recommended, as GCC seems to cause some issues

@sedmicha
Copy link
Collaborator Author

@mzary

mzary added a commit to mzary/ipfixcol2 that referenced this pull request Mar 21, 2024
(the most recent commit to bsd-support branch) to test[1].
The port builds fine and passes runtime tests.

1. CESNET/ipfixcol2#94 (comment)
@mzary
Copy link

mzary commented Mar 21, 2024

Everything builds and runs fine on FreeBSD 14.0-STABLE as far as I was able to test.

@mzary
Copy link

mzary commented Apr 4, 2024

So far the daemon runs fine, log files are stored and readable, and the plugins which I was able to test seem to work fine.
I have updated https://github.com/mzary/ipfixcol2/tree/main but it's probably not ready for submission to FreeBSD ports tree yet. We can do it when the bsd-support branch is merged with the master and a new release will be prepared.

The port of libfds is ready for submission, but it will be nice to incorporate this patch[1] in future releases of this library if it won't break Linux builds.

  1. https://github.com/mzary/ipfixcol2/blob/main/net-mgmt/libfds/files/patch-include_libfds_converters.h

@sedmicha
Copy link
Collaborator Author

sedmicha commented Apr 5, 2024

So far the daemon runs fine, log files are stored and readable, and the plugins which I was able to test seem to work fine. I have updated https://github.com/mzary/ipfixcol2/tree/main but it's probably not ready for submission to FreeBSD ports tree yet. We can do it when the bsd-support branch is merged with the master and a new release will be prepared.

The port of libfds is ready for submission, but it will be nice to incorporate this patch[1] in future releases of this library if it won't break Linux builds.

  1. https://github.com/mzary/ipfixcol2/blob/main/net-mgmt/libfds/files/patch-include_libfds_converters.h

Thank you for your testing efforts, I appreciate it. We have been a bit too busy with other projects lately, but I am still keeping an eye on this.

@mzary
Copy link

mzary commented Jul 30, 2024

I just wanted to let you know, that after half a year, after a few rebuilds and updates of the underlying OS and software, the daemon still runs fine and does the job as intended. I still hope that BSD-related patches will get merged into the main branch and that a new release will be created, but if you don't plan to merge BSD patches soon, perhaps it's the right time to create a port for FreeBSD and base it on bsd-support branch, since the software is reliable and does the job fine.

@Lukas955 Lukas955 merged commit 10833f2 into master Aug 2, 2024
32 checks passed
@Lukas955
Copy link
Collaborator

Lukas955 commented Aug 2, 2024

Thanks for the feedback, the fixes are now part of the main branch.

@mzary
Copy link

mzary commented Aug 3, 2024

Thank you for merging the branches. I will prepare the port for the FreeBSD ports tree and submit it next week, but it will be easier to base it on the tag instead of hooking it on the commit hash. Do you plan a new release soon?

@sedmicha
Copy link
Collaborator Author

sedmicha commented Aug 5, 2024

Thank you for merging the branches. I will prepare the port for the FreeBSD ports tree and submit it next week, but it will be easier to base it on the tag instead of hooking it on the commit hash. Do you plan a new release soon?

Thank you for your support. We have just released ipfixcol2 v2.6.0 and libfds v0.6.0 which include the necessary changes for BSD support.

@mzary
Copy link

mzary commented Aug 5, 2024

Thank you very much for your effort in making ipfixcol2 work under FreeBSD. By the end of the week, I will submit the PRs (problem reports) to introduce libfds and ipfixcol2 to the FreeBSD ports tree. I hope they will get accepted and committed soon. I will keep you updated.

@mzary
Copy link

mzary commented Aug 14, 2024

Two new ports have just officially entered the FreeBSD ports tree[1][2]. Now it's time to get ready for more bug reports ;-)
Thanks again to @sedmicha, @Lukas955 and all the CESNET staff for their efforts to modify the code to be BSD-friendly, without which this would never have been possible. Many thanks also to eugen(at)freebsd.org for quickly committing these ports. Thanks to @yellowman for the initial pull request.

  1. freebsd/freebsd-ports@cddafad
  2. freebsd/freebsd-ports@ce7dc5c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants