Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Observer #2265

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Refactor Observer #2265

merged 1 commit into from
Nov 16, 2024

Conversation

ajtribick
Copy link
Collaborator

@ajtribick ajtribick commented Nov 16, 2024 •
edited
Loading

Remove namespace std, fix some const issues, use enum class, split up some overly large methods

@ajtribick ajtribick force-pushed the observer-refactor branch 4 times, most recently from 9b93edd to 0b1b599 Compare November 16, 2024 11:18
@ajtribick
Refactor Observer
84c7c6c 
- Remove using namespace std
- Simplify some methods
- Use enum classes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ajtribick ajtribick marked this pull request as ready for review November 16, 2024 14:10
@ajtribick ajtribick merged commit 80334d0 into master Nov 16, 2024
9 checks passed
@ajtribick ajtribick deleted the observer-refactor branch November 16, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@375gnu 375gnu 375gnu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajtribick @375gnu