Updated the base node image in Dockerfile #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumanjeet0012
requested review from
bajtos,
juliangruber,
pyropy and
NikolasHaimerl
as code owners
juliangruber
approved these changes
Jan 31, 2025
pyropy
requested changes
Jan 31, 2025
There was a problem hiding this comment.
@sumanjeet0012 Thank you so much for submitting this PR! 🎉
Please consider upgrading Node JS version in Github Workflow CI script.
You might ask yourself why is this important? We want to make sure that all checks, including our tests, are running the same version of Node JS in the production as well as during our CI workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Fixes CheckerNetwork/roadmap#210
Updated the Node.js base image from node:20.12.2-slim to node:22.13.1-slim, an LTS version, as requested in issue #210 of the roadmap repository.