Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHIA-2281 Clarify transactions generator check in test_parser #19205

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AmineKhaldi
Copy link
Contributor

Both gen and block.transactions_generator are Optional.

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Jan 29, 2025
@AmineKhaldi AmineKhaldi self-assigned this Jan 29, 2025
Copy link

Pull Request Test Coverage Report for Build 13029511444

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • 13 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.004%) to 91.512%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/_tests/util/test_full_block_utils.py 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.45%
chia/util/config.py 1 84.62%
chia/rpc/rpc_server.py 1 89.16%
chia/full_node/full_node.py 1 86.22%
chia/server/node_discovery.py 2 79.49%
chia/daemon/server.py 7 83.46%
Totals Coverage Status
Change from base Build 13019247618: 0.004%
Covered Lines: 105268
Relevant Lines: 114853

💛 - Coveralls

@AmineKhaldi AmineKhaldi marked this pull request as ready for review January 31, 2025 11:02
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner January 31, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant