Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beta fixes #788

Merged
merged 27 commits into from
Jan 6, 2025
Merged

Beta fixes #788

merged 27 commits into from
Jan 6, 2025

Conversation

digimer
Copy link
Member

@digimer digimer commented Jan 1, 2025 •
edited
Loading

@digimer-bot
Reworked anvil-change-password to deal with issue 761.
3780ba1 
Signed-off-by: Madison Kelly <[email protected]>
@digimer-bot
Fixed a bug where jobs were not set to 100% when complete.
c746a1f 
Signed-off-by: Madison Kelly <[email protected]>
@digimer-bot
Fixed a bug where --resync-db would cause a resync every loop in daemons
f33b517 
Signed-off-by: Madison Kelly <[email protected]>
@digimer-bot
Updated Tools->refresh() to clear --resync-db and --age-out-database.
2ba8358 
Signed-off-by: Madison Kelly <[email protected]>
@digimer-bot
Fixed a small logging bug
5e6b078 
Signed-off-by: Madison Kelly <[email protected]>
@digimer-bot
Cleaned up logging
e32556e 
Signed-off-by: Madison Kelly <[email protected]>
@digimer-bot
Fixed a bug where host_type was set to host_uuid.
8a0d472 
Signed-off-by: Madison Kelly <[email protected]>
@digimer-bot
Short-circuited the no-longer-used Account->logout().
a67b9d8 
Signed-off-by: Madison Kelly <[email protected]>
@digimer-bot
Added log switches when updating passwords on peer machines.
98e5a33 
Signed-off-by: Madison Kelly <[email protected]>
@digimer-bot
Fixed a logging bug while updating anvil.conf.
4375cbf 
Signed-off-by: Madison Kelly <[email protected]>
@digimer-bot
Improved logging for updating anvil.conf
5cac32a 
Signed-off-by: Madison Kelly <[email protected]>
@digimer-bot
Fixed a bug where anvil-change-password wasn't being called on other
6686857 
hosts.

Signed-off-by: Madison Kelly <[email protected]>
@digimer-bot
Added the missing '--confirm' when updating the password on other hosts.
27ec536 
Signed-off-by: Madison Kelly <[email protected]>
@digimer-bot
Added the function to remove the password file when --delete-pw is used.
28b2af4 
Signed-off-by: Madison Kelly <[email protected]>
@digimer-bot
Finished the new core logic for anvil-change-password.
74e3e6d 
* Improved where --delete-pw is honoured so it's removed quicker
* Added 'update_anvils()' to update the Anvil! password after the
  subondes are updated (which will trigger IPMI pw updates)
* Added tests of known passwords when a connection to another host fails
  without a password.
* The successful password and target IP are cached.

Signed-off-by: Madison Kelly <[email protected]>
@digimer-bot
Converted raw prints to translated strings.
73971d8 
Signed-off-by: Madison Kelly <[email protected]>
@digimer digimer requested a review from fabbione January 1, 2025 22:24
@digimer
Copy link
Member Author

digimer commented Jan 1, 2025

retest this please

@digimer-bot
Completed the man page for anvil-manage-server-system.
a3a8584 
This closes issue #739

Signed-off-by: Madison Kelly <[email protected]>
@digimer-bot
Fixed bugs that were breaking CI.
c92beea 
* Added '--no-wait' to bypass waiting on running jobs in anvil-change-password
* Updated anvil-configure-host's call to anvil-change-password

Signed-off-by: Madison Kelly <[email protected]>
@digimer-bot
Create a job for the other host instead of simply exiting when the
459ed31 
server is running elsewhere in the cluster.

* Also added a check to skip hosts that are not related to the server
  being worked on.

Signed-off-by: Madison Kelly <[email protected]>
@digimer-bot
Added 'ping' to Network->find_target_ip to ping test before ssh testing.
343eb09 
* Changed progress tracking in anvil-manage-server-storage to use
  Job->bump_progress.

Signed-off-by: Madison Kelly <[email protected]>
@digimer-bot
Updated Network->find_target_ip() to return the name of the network the
afb618b 
target IP belongs to.

Signed-off-by: Madison Kelly <[email protected]>
@digimer-bot
Added job progress/logging to show peer connection testing.
af7f573 
Signed-off-by: Madison Kelly <[email protected]>
@digimer-bot
Removed a debug 'die' call.
4a5265c 
Signed-off-by: Madison Kelly <[email protected]>
@digimer-bot
Added more checks to ignore unrelated hosts.
f4b78f8 
Signed-off-by: Madison Kelly <[email protected]>
@digimer-bot
Added scan-drbd calls after bringing up new resources before the initial
4dbe2bb 
forced primary.

Signed-off-by: Madison Kelly <[email protected]>
@digimer-bot
Fixed bugs in anvil-manage-server-storage, works again to add disks.
e3ffd5d 
* Moved a couple string keys to avoid conflicts with another PR.

Signed-off-by: Madison Kelly <[email protected]>
@digimer-bot
Added Words->escape_xml() to quote strings used in XML.
4e040fb 
This resolves issue #656.

Signed-off-by: Madison Kelly <[email protected]>
fabbione
fabbione approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@fabbione fabbione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks ok. I can´t speak for the major changes in update password, but it is used for auto deployment in CI and CI is passing for now.

@digimer digimer merged commit bec87a0 into main Jan 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabbione fabbione fabbione approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@digimer @fabbione @digimer-bot