Dev: ra: Prevent to add unknown operation

- When adding unknown operation, sanity check should give an error instead of a warning
- And sanity check will return a big number to indicate this is a fatal
  error, so that the commit process will be aborted

crmsh/constants.py

@@ -453,4 +453,6 @@
 
 PCMK_SERVICE = "pacemaker.service"
 SBD_SERVICE = "sbd.service"
+
+SANITY_FATAL_RC = 100
 # vim:ts=4:sw=4:et:

crmsh/ra.py

@@ -592,8 +592,8 @@ def sanity_check_op(op, op_dict):
             if self.ra_class == "stonith" and op in ("start", "stop"):
                 return rc
             if op not in self.actions():
-                logger.warning("%s: action '%s' not found in Resource Agent meta-data", ident, op)
-                rc |= 1
+                logger.error("Action '%s' not found in Resource Agent meta-data", op)
+                rc |= constants.SANITY_FATAL_RC
                 return rc
             rc |= sanity_check_op_interval(op, op_dict)
             rc |= sanity_check_op_timeout(op, op_dict)

crmsh/ui_configure.py

@@ -744,6 +744,8 @@ def _verify(self, set_obj_semantic, set_obj_all):
         rc1 = set_obj_all.verify()
         if config.core.check_frequency != "never":
             rc2 = set_obj_semantic.semantic_check(set_obj_all)
+            if rc2 >= constants.SANITY_FATAL_RC:
+                cib_factory.reset()
         else:
             rc2 = 0
         return rc1 and rc2 <= 1
@@ -926,6 +928,8 @@ def _commit(self, force=False, replace=False):
         rc2 = self._verify(mkset_obj("xml", "changed"), mkset_obj("xml"))
         if rc1 and rc2:
             return cib_factory.commit(replace=replace)
+        if not cib_factory.has_cib_changed():
+            return False
         if force or config.core.force:
             logger.info("commit forced")
             return cib_factory.commit(force=True, replace=replace)