Skip to content

Commit

Permalink
Dev: migration: check if the cluster is already migrated to SLES 16 (…
Browse files Browse the repository at this point in the history 
…jsc#PED-8252)

* should not run the migration if already migrated
* should not tell users to run `crm cluster health sles16 --fix` if
  already migrated
  • Loading branch information
@nicholasyang2022
nicholasyang2022 committed Feb 19, 2025
1 parent b96f625 commit a5c18a6
Show file tree
Hide file tree
Showing 2 changed files with 63 additions and 39 deletions.
98 changes: 60 additions & 38 deletions crmsh/migration.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ def end(self):
class CheckResultInteractiveHandler(CheckResultHandler):
def __init__(self):
self.has_problems = False
self.has_tips = False

def log_info(self, fmt: str, *args):
self.write_in_color(sys.stdout, constants.GREEN, '[INFO] ')
Expand All @@ -108,6 +109,7 @@ def handle_problem(self, is_fatal: bool, title: str, details: typing.Iterable[st
raise MigrationFailure('Unable to start migration.')

Check warning on line 109 in crmsh/migration.py

View check run for this annotation

Codecov / codecov/patch

crmsh/migration.py#L109 

Added line #L109 was not covered by tests

def handle_tip(self, title: str, details: typing.Iterable[str]):
self.has_tips = True
self.write_in_color(sys.stdout, constants.YELLOW, '[WARN] ')
print(title)
for line in details:
Expand All @@ -129,12 +131,17 @@ def end(self):

def migrate():
try:
if 0 != _check_impl(local=False, json='', summary=False):
raise MigrationFailure('Unable to start migration.')
logger.info('Starting migration...')
migrate_corosync_conf()
logger.info('Finished migration.')
return 0
match _check_impl(local=False, json='', summary=False):
case 0:
logger.info("This cluster works on SLES 16. No migration is needed.")
return 0
case 1:
logger.info('Starting migration...')
migrate_corosync_conf()
logger.info('Finished migration.')
return 0
case _:
raise MigrationFailure('Unable to start migration.')
except MigrationFailure as e:
logger.error('%s', e)
return 1

Check warning on line 147 in crmsh/migration.py

View check run for this annotation

Codecov / codecov/patch

crmsh/migration.py#L143-L147 

Added lines #L143 - L147 were not covered by tests
Expand All @@ -148,18 +155,26 @@ def check(args: typing.Sequence[str]) -> int:
ret = _check_impl(parsed_args.local or parsed_args.json is not None, parsed_args.json, parsed_args.json is None)
if not parsed_args.json:
print('****** summary ******')
if ret == 0:
CheckResultInteractiveHandler.write_in_color(sys.stdout, constants.GREEN, '[INFO]')
sys.stdout.write(' Please run "crm cluster health sles16 --fix" on on any one of above nodes.\n')
CheckResultInteractiveHandler.write_in_color(sys.stdout, constants.GREEN, '[PASS]')
sys.stdout.write(' This cluster is good to migrate to SLES 16.\n')
else:
CheckResultInteractiveHandler.write_in_color(sys.stdout, constants.RED, '[FAIL]')
sys.stdout.write(' The pacemaker cluster stack can not migrate to SLES 16.\n')
match ret:
case 0:
CheckResultInteractiveHandler.write_in_color(sys.stdout, constants.GREEN, '[INFO]')
sys.stdout.write(' This cluster works on SLES 16. No migration is needed.\n')
case 1:
CheckResultInteractiveHandler.write_in_color(sys.stdout, constants.GREEN, '[INFO]')
sys.stdout.write(' Please run "crm cluster health sles16 --fix" on on any one of above nodes.\n')
CheckResultInteractiveHandler.write_in_color(sys.stdout, constants.GREEN, '[PASS]')
sys.stdout.write(' This cluster is good to migrate to SLES 16.\n')
case _:
CheckResultInteractiveHandler.write_in_color(sys.stdout, constants.RED, '[FAIL]')
sys.stdout.write(' The pacemaker cluster stack can not migrate to SLES 16.\n')
return ret


def _check_impl(local: bool, json: str, summary: bool):
def _check_impl(local: bool, json: str, summary: bool) -> int:
"""Return:
* 0 if the cluster is already on SLES 16.
* 1 if the cluster is good to migrate to SLES 16.
* 2 if the cluster is not good to migrate to SLES 16."""
assert not summary or not bool(json)
assert local or not bool(json)
ret = 0
Expand Down Expand Up @@ -189,10 +204,19 @@ def _check_impl(local: bool, json: str, summary: bool):
handler.end()
match handler:
case CheckResultJsonHandler():
ret = 0 if handler.json_result["pass"] else 1
if not handler.json_result["pass"]:
ret = 2
elif handler.json_result['tips']:
ret = 1
else:
ret = 0
case CheckResultInteractiveHandler():
if handler.has_problems:
ret = 2
elif handler.has_tips:
ret = 1
else:
ret = 0
if check_remote_yield:
remote_ret = next(check_remote_yield)
if remote_ret > ret:
Expand Down Expand Up @@ -230,35 +254,33 @@ def run(self):
sys.stdout.write('\n')
ret = 255
case prun.ProcessResult() as result:
if result.returncode > 1:
try:
check_result = json.loads(result.stdout.decode('utf-8'))
except (UnicodeDecodeError, json.JSONDecodeError):
print(result.stdout.decode('utf-8', 'backslashreplace'))
handler.write_in_color(

Check warning on line 261 in crmsh/migration.py

View check run for this annotation

Codecov / codecov/patch

crmsh/migration.py#L259-L261 

Added lines #L259 - L261 were not covered by tests
sys.stdout, constants.YELLOW,
sys.stderr, constants.YELLOW,
result.stderr.decode('utf-8', 'backslashreplace')
)
sys.stdout.write('\n')

Check warning on line 265 in crmsh/migration.py

View check run for this annotation

Codecov / codecov/patch

crmsh/migration.py#L265 

Added line #L265 was not covered by tests
ret = result.returncode
# cannot pass the exit status through,
# as all failed exit status become 1 in ui_context.Context.run()
ret = 2

Check warning on line 268 in crmsh/migration.py

View check run for this annotation

Codecov / codecov/patch

crmsh/migration.py#L268 

Added line #L268 was not covered by tests
else:
try:
result = json.loads(result.stdout.decode('utf-8'))
except (UnicodeDecodeError, json.JSONDecodeError):
print(result.stdout.decode('utf-8', 'backslashreplace'))
handler.write_in_color(
sys.stdout, constants.YELLOW,
result.stdout.decode('utf-8', 'backslashreplace')
)
sys.stdout.write('\n')
ret = result.returncode
passed = check_result.get("pass", False)
handler = CheckResultInteractiveHandler()
for problem in check_result.get("problems", list()):
handler.handle_problem(False, problem.get("title", ""), problem.get("descriptions"))
tips = check_result.get('tips', list())
for tip in tips:
handler.handle_tip(tip.get("title", ""), tip.get("descriptions"))
handler.end()
if not passed:
ret = 2
elif tips:
ret = 1
else:
passed = result.get("pass", False)
handler = CheckResultInteractiveHandler()
for problem in result.get("problems", list()):
handler.handle_problem(False, problem.get("title", ""), problem.get("descriptions"))
for tip in result.get("tips", list()):
handler.handle_tip(tip.get("title", ""), tip.get("descriptions"))
handler.end()
if not passed:
ret = 1
ret = result.returncode
yield ret


Expand Down
4 changes: 3 additions & 1 deletion test/features/migration.feature
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ Feature: migration
And Run "crm cluster stop --all" on "hanode2"
And Try "crm cluster health sles16" on "hanode1"
Then Expected return code is "0"
And Expected "[INFO] This cluster works on SLES 16. No migration is needed." in stdout


Scenario: Should run fixes.
When Try "crm cluster health sles16 --fix" on "hanode1"
Expand Down Expand Up @@ -87,7 +89,7 @@ Feature: migration
"""
And Run "crm cluster copy /etc/corosync/corosync.conf" on "hanode1"
And Try "crm cluster health sles16" on "hanode1"
Then Expected return code is "0"
Then Expected return code is "1"
And Expect stdout contains snippets ["[PASS] This cluster is good to migrate to SLES 16.", "[INFO] Please run \"crm cluster health sles16 --fix\" on on any one of above nodes.", "[WARN] Corosync transport \"udpu\" will be deprecated in corosync 3. Please use knet.", "----- localhost -----", "----- hanode2 -----"].

Scenario: Run fixes against corosync.conf generated in crmsh-4.6
Expand Down

0 comments on commit a5c18a6

Please sign in to comment.