Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: ui_configure: Remove 'ms' sub-command #1663

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

liangxin1300
Copy link
Collaborator

@liangxin1300 liangxin1300 commented Jan 12, 2025

As pacemaker 3.0 already dropped support for deprecated master resources [1][2]

Other changes:

  • Dev: parse: Remove codes that are used to parse the master resource
  • Dev: Remove 'master' and 'ms' terminology

[1] https://github.com/ClusterLabs/pacemaker/blob/main/xml/resources-4.0.rng#L19-L30
[2] https://github.com/ClusterLabs/pacemaker/releases/tag/Pacemaker-3.0.0

@liangxin1300 liangxin1300 force-pushed the 20250112_drop_ms_command branch from df6279f to 73610a3 Compare January 12, 2025 09:16
@liangxin1300 liangxin1300 force-pushed the 20250112_drop_ms_command branch 2 times, most recently from 8e6e749 to af30ed3 Compare January 12, 2025 09:51
@liangxin1300 liangxin1300 force-pushed the 20250112_drop_ms_command branch from af30ed3 to f7f69bc Compare January 12, 2025 10:10
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 68.29268% with 13 lines in your changes missing coverage. Please review.

Project coverage is 69.74%. Comparing base (9dcea10) to head (f7f69bc).

Files with missing lines Patch % Lines
crmsh/cibconfig.py 25.00% 6 Missing ⚠️
crmsh/rsctest.py 69.23% 4 Missing ⚠️
crmsh/xmlutil.py 71.42% 2 Missing ⚠️
crmsh/completers.py 0.00% 1 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 53.55% <65.85%> (-0.01%) ⬇️
unit 53.09% <43.90%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/cmd_status.py 77.41% <100.00%> (ø)
crmsh/constants.py 100.00% <100.00%> (ø)
crmsh/logparser.py 71.28% <100.00%> (ø)
crmsh/parse.py 81.53% <100.00%> (-0.06%) ⬇️
crmsh/ui_configure.py 45.11% <ø> (+0.05%) ⬆️
crmsh/ui_resource.py 72.69% <100.00%> (ø)
crmsh/completers.py 57.77% <0.00%> (ø)
crmsh/xmlutil.py 69.25% <71.42%> (-0.07%) ⬇️
crmsh/rsctest.py 64.83% <69.23%> (+0.09%) ⬆️
crmsh/cibconfig.py 64.64% <25.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zzhou1
Copy link
Contributor

zzhou1 commented Feb 10, 2025

TODO in man crm to drop a couple of sentences :

  • " It’s used to deprecate the master-slave resources. "

  • " The Master/Slave resources are deprecated and replaced by Promoted/Unpromoted promotable resources if desired. "

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants