Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crmsh-4.6] Fix: ra: Prevent to add unknown operation (bsc#1236442) #1680

Open
wants to merge 3 commits into
base: crmsh-4.6
Choose a base branch
from

Conversation

liangxin1300
Copy link
Collaborator

  • When adding unknown operation, sanity check should give an error instead of a warning
  • And sanity check will return a big number to indicate this is a fatal error, so that the commit process will be aborted

backport #1679

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.85%. Comparing base (c736573) to head (d973d65).

Files with missing lines Patch % Lines
crmsh/utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 52.67% <90.00%> (+0.04%) ⬆️
unit 49.37% <10.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/constants.py 100.00% <100.00%> (ø)
crmsh/ra.py 54.35% <100.00%> (+0.44%) ⬆️
crmsh/ui_configure.py 45.53% <100.00%> (+0.31%) ⬆️
crmsh/utils.py 66.04% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300 liangxin1300 marked this pull request as ready for review February 5, 2025 07:58
- When adding unknown operation, sanity check should give an error instead of a warning
- And sanity check will return a big number to indicate this is a fatal
  error, so that the commit process will be aborted
Avoid get empty options in else case
@liangxin1300 liangxin1300 force-pushed the 20250113_prevent_unknown_op_crmsh46 branch from 6e804bf to d973d65 Compare February 14, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant