Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: testcases: Adjust original test cases to match pacemaker-3 #1688

Conversation

liangxin1300
Copy link
Collaborator

@liangxin1300 liangxin1300 commented Feb 12, 2025

Major changes:

  • Remove stonith:null and stonith:ssh in original test cases
  • Set stonith-enabled=false to avoid config error

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.71%. Comparing base (e63ac0b) to head (e9da0c3).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
crmsh/ui_cib.py 0.00% 1 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 53.52% <0.00%> (ø)
unit 53.08% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/ui_cib.py 30.12% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300
Copy link
Collaborator Author

This PR can be merged when pacemaker 3 is available at CI image

@liangxin1300 liangxin1300 changed the title TEMP: to see the test results Dev: testcases: Adjust original test cases to match pacemaker-3 Feb 13, 2025
@liangxin1300 liangxin1300 force-pushed the 20250212_update_pacemaker_to_see_the_test branch 2 times, most recently from c4da843 to b5efad4 Compare February 13, 2025 09:16
@liangxin1300 liangxin1300 force-pushed the 20250212_update_pacemaker_to_see_the_test branch from 476de2a to e9da0c3 Compare February 14, 2025 09:16
@liangxin1300 liangxin1300 marked this pull request as ready for review February 14, 2025 09:29
@nicholasyang2022 nicholasyang2022 merged commit 8bb3232 into ClusterLabs:master Feb 17, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants