Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[crmsh-4.6] Improve configure schema command #1691

Merged
merged 4 commits into from
Feb 18, 2025
Merged

[crmsh-4.6] Improve configure schema command #1691

merged 4 commits into from
Feb 18, 2025

Conversation

liangxin1300
Copy link
Collaborator

backport #1690

@liangxin1300
Dev: schema: Make sure schema changed after setting new schema by `co…
cc57aae 
…nfigure schema`

Also return False if schema is not supported.
@codecov Codecov
Copy link

codecov bot commented Feb 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.84%. Comparing base (c736573) to head (d59ea7a).
Report is 5 commits behind head on crmsh-4.6.

Additional details and impacted files
Flag Coverage Δ
integration 52.71% <100.00%> (+0.08%) ⬆️
unit 49.37% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/cibconfig.py 64.36% <100.00%> (+0.08%) ⬆️
crmsh/schema.py 84.21% <100.00%> (+1.54%) ⬆️
crmsh/ui_configure.py 45.74% <100.00%> (+0.52%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300 liangxin1300 force-pushed the 20250214_schema_improve_crmsh46 branch from b6205ba to dddcb3c Compare February 18, 2025 02:13
@liangxin1300 liangxin1300 force-pushed the 20250214_schema_improve_crmsh46 branch from dddcb3c to d59ea7a Compare February 18, 2025 06:41
@liangxin1300 liangxin1300 marked this pull request as ready for review February 18, 2025 06:42
@liangxin1300 liangxin1300 merged commit 34cf2a4 into ClusterLabs:crmsh-4.6 Feb 18, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzhou1 zzhou1 zzhou1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liangxin1300 @zzhou1