Api: ✏️ Modify the format of chat search api #182
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 이유
작업 사항
1️⃣ Slice 응답 포맷
2️⃣ SQL Injection Defense
JPA는 기본적으로 SQL Injection 공격을 방어해주긴 하지만,
JPA와 JPASQLQuery를 혼용하고 있기 때문에 혹시나 싶은 상황에 대비하여 몇 가지 키워드를 target parameter로 전달해보았습니다.
;delete from chat_room where id=4;
;drop table chat_room;
;delete from user;
머쓱할 정도로 잘 막아주더라구요. 허허.
SQLQueryFactory를 사용하지 않아서, Hibernate 기반의 SQL을 실행할 수 있기 때문에 괜찮다고 판단하였습니다.
리뷰어가 중점적으로 확인해야 하는 부분
발견한 이슈