Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socket: 🔧 The server sends a success message after a chat message is saved successfully #214

Merged
merged 5 commits into from
Jan 7, 2025

Conversation

psychology50
Copy link
Member

작업 이유


작업 사항

image

  • The server sends a message that includes x-message-id to success queue after the chat message is successfully published.

리뷰어가 중점적으로 확인해야 하는 부분

  • Since I am not very experienced with Kotlin, please review the code style.

발견한 이슈

  • When the client tries to subscribe, if the receipt header is missing, the server throws an error. 😅

@psychology50 psychology50 added enhancement New feature or request fix 기능 수정 labels Jan 7, 2025
@psychology50 psychology50 self-assigned this Jan 7, 2025
@psychology50 psychology50 merged commit 092e7aa into dev Jan 7, 2025
1 check passed
@psychology50 psychology50 deleted the feat/PW-675-success-chat-message branch January 7, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fix 기능 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant