Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingore: 🐛 Improvement of Log System and Update Chat Room API #223

Merged
merged 5 commits into from
Jan 17, 2025

Conversation

psychology50
Copy link
Member

@psychology50 psychology50 commented Jan 17, 2025

작업 이유

  • We couldn’t check the presentation layer’s logs after switching to logback.
  • Clients receive a 403 error response when attempting to update a chat room, even though they are sending the correct data.

작업 사항

  • Added appenders to the web and socket modules.
  • Fixed the chat room update service logic.

리뷰어가 중점적으로 확인해야 하는 부분

  • none

발견한 이슈

  1. Long-type variables are returned correctly on the server, but the last 2 bits are lost in the Swagger documentation.
  2. Forgot to fix the service logic where the chat member search service should join with the user table.

@psychology50 psychology50 added the enhancement New feature or request label Jan 17, 2025
@psychology50 psychology50 self-assigned this Jan 17, 2025
@psychology50 psychology50 merged commit 34bede3 into dev Jan 17, 2025
1 check passed
@psychology50 psychology50 deleted the fix/has-admin-permission branch January 17, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant