Fix: newly unpowered smart chutes don't ignore vault version tracker #6770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IThundxr
added
pr type: fix
|
Thank you for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Fixes #6154
Fixes #5867
Implemented Solution
At runtime, save an additional boolean in a ChuteBlockEntity that gets toggled when we toggle the powered state to off (in SmartChuteBlock):
If that's set to true, don't check whether we're still waiting on the versioned inventory tracker, just go through with the transfer attempt, then toggle it back to false so subsequent attempts to check the versioned inventory tracker aren't skipped.
This boolean doesn't need to be saved to disk I don't think, we seem to get a new versioned inventory tracker when the world is loaded that we can't yet be waiting on.
This does introduce some useless logic (a boolean comparison and setting a boolean to false) for normal chutes as the transferring logic is in ChuteBlockEntity, but at least we never toggle it to true for those.