Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace BYG compat with Biomes We've Gone Compat #7345

Closed

Conversation

JT122406
Copy link

https://www.curseforge.com/minecraft/mc-mods/oh-the-biomes-weve-gone
this is the sequel to byg for 1.20.1+ (I am the developer of this mod) lmk if anything else is needed, I will probably do more work on this in the future

@VoidLeech
Copy link
Contributor

The bulk of this is a duplicate of #7320, though I do see some differences:

  • Red rock crushing recipe.
  • Some bugs in the cutting recipe gen: florus has a stem, not a log, and so shouldn't be in cuttingCompat
  • BWG doesn't have a mangrove wood type
  • The other pr adds some new milling recipes for new flowers and adjusts where you've renamed or removed flowers.
  • The path pressing should be lush_dirt, not lush_grass
  • This pr actually updates the modded stripped logs tags

cc @Attack8

@Attack8
Copy link
Contributor

Attack8 commented Feb 12, 2025

I will merge this into my mmc-6 branch, keeping in mind your notes

@IThundxr IThundxr added the pr type: feature PR adds a new feature or changes an existing feature label Feb 12, 2025
Copy link
Member

@IThundxr IThundxr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a quick look everything looks good, however please revert the changes to CuttingRecipeGen, as those changes will conflict with changes made in the next update

@Attack8
Copy link
Contributor

Attack8 commented Feb 12, 2025

From a quick look everything looks good, however please revert the changes to CuttingRecipeGen, as those changes will conflict with changes made in the next update

I will keep this in mind when making changes to mmc-6, this pr will be replaced my pr on the same topic. This pr does bring up some good points however, which I will change in mine

@JT122406
Copy link
Author

I’ll just close this if another pr has this I was just getting annoyed with people asking me why compat wasn’t working

@JT122406 JT122406 closed this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr type: feature PR adds a new feature or changes an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants