-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add servable editing to sdk #161
Open
isaac-darling
wants to merge
18
commits into
dev
Choose a base branch
from
servable-edit
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auth issues are fixed, but fails on incompatible typing syntax in Python 3.7 and 3.8, and in 3.9 and 3.10 we get the following error:
Requires additional refactoring before merge is possible |
I thought this might happen, so I prepared a possible solution. Hopefully it helps :) |
Dev -- funcx 1.0.x compatibility
Pull Request Test Coverage Report for Build 3064702654
💛 - Coveralls |
putting a pin in this until we have clarity on whether or not we're moving to a serverless architecture |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready to be merged yet, remains untested. The DLHub Service has a corresponding update that adds the route this method requires. Considerations for deleting servables are also included, but the
delete_servable
function is not yet implemented.