Skip to content

Commit

Permalink
CI fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
prasannavl committed Jan 4, 2025
1 parent 1d8dba2 commit e3b717f
Show file tree
Hide file tree
Showing 5 changed files with 1,074 additions and 924 deletions.
9 changes: 6 additions & 3 deletions .github/workflows/ci-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ concurrency:
jobs:
main:
name: Cypress
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository
strategy:
fail-fast: false # https://github.com/cypress-io/github-action/issues/48
Expand All @@ -25,7 +25,10 @@ jobs:
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1

- run: corepack enable pnpm

- name: Setup cypress deps
run: |
sudo apt update && sudo apt-get install -y libgtk2.0-0 libgtk-3-0 libgbm-dev libnotify-dev libnss3 libxss1 libasound2 libxtst6 xauth xvfb
- uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
with:
Expand All @@ -44,7 +47,7 @@ jobs:
build: npm run cypress:build
start: npm run start
wait-on: "http://localhost:3000"
browser: chrome
browser: electron
spec: cypress/e2e/**
tag: ${{ github.event_name }}
env:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ jobs:
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1

- run: corepack enable pnpm

- uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
with:
node-version-file: ".nvmrc"
Expand Down
5 changes: 3 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
FROM node:18-alpine AS base
FROM node:18 AS base

WORKDIR /app

COPY package.json .
COPY package-lock.json .
RUN npm install --include=dev
# Install both dependencies and devDependencies
RUN npm ci

COPY . .

Expand Down
Loading

0 comments on commit e3b717f

Please sign in to comment.