Clang-Tidy: Update performance and readability

For performance and readability, instead of including checks explicitly,
switch to excluding checks explicitly. These checks are excluded because
currently WarpX fails at them.

.clang-tidy

@@ -29,38 +29,24 @@ Checks: '
         -modernize-return-braced-init-list,
         -modernize-use-trailing-return-type,
     mpi-*,
-    performance-faster-string-find,
-    performance-for-range-copy,
-    performance-implicit-conversion-in-loop,
-    performance-inefficient-algorithm,
-    performance-inefficient-string-concatenation,
-    performance-inefficient-vector-operation,
-    performance-move-const-arg,
-    performance-move-constructor-init,
-    performance-no-automatic-move,
-    performance-no-int-to-ptr,
-    readability-avoid-const-params-in-decls,
-    readability-const-return-type,
-    readability-container-contains,
-    readability-container-data-pointer,
-    readability-container-size-empty,
-    readability-non-const-parameter,
-    readability-redundant-control-flow,
-    readability-redundant-declaration,
-    readability-redundant-function-ptr-dereference,
-    readability-redundant-member-init,
-    readability-redundant-preprocessor,
-    readability-redundant-smartptr-get,
-    readability-redundant-string-cstr,
-    readability-redundant-string-init,
-    readability-simplify-boolean-expr,
-    readability-simplify-subscript-expr,
-    readability-static-accessed-through-instance,
-    readability-static-definition-in-anonymous-namespace,
-    readability-string-compare,
-    readability-suspicious-call-argument,
-    readability-uniqueptr-delete-release,
-    readability-use-anyofallof,
+    performance-*,
+        -performance-noexcept-move-constructor,
+        -performance-unnecessary-copy-initialization,
+        -performance-unnecessary-value-param,
+    readability-*,
+        -readability-braces-around-statements,
+        -readability-convert-member-functions-to-static,
+        -readability-duplicate-include,
+        -readability-else-after-return,
+        -readability-function-cognitive-complexity,
+        -readability-identifier-length,
+        -readability-implicit-bool-conversion,
+        -readability-inconsistent-declaration-parameter-name,
+        -readability-isolate-declaration,
+        -readability-magic-numbers,
+        -readability-make-member-function-const,
+        -readability-named-parameter,
+        -readability-qualified-auto,
         -readability-uppercase-literal-suffix
     '
 

.github/workflows/clang_tidy.yml

@@ -50,7 +50,7 @@ jobs:
         cmake --build build_clang_tidy -j 2
 
         ${{github.workspace}}/.github/workflows/source/makeMakefileForClangTidy.py --input ${{github.workspace}}/ccache.log.txt
-        make -j2 -f clang-tidy-ccache-misses.mak \
+        make -j2 --keep-going -f clang-tidy-ccache-misses.mak \
             CLANG_TIDY=clang-tidy \
             CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*"
 

Source/Initialization/InjectorMomentum.H

@@ -341,7 +341,7 @@ struct InjectorMomentumBoltzmann
         for (auto& el : u) el = 0.0_rt;
         const amrex::Real beta = velocity(x,y,z);
         int const dir = velocity.direction();
-        const auto gamma = static_cast<amrex::Real>(1._rt/sqrt(1._rt-beta*beta));
+        const auto gamma = 1._rt/std::sqrt(1._rt-beta*beta);
         u[dir] = gamma*beta;
         return amrex::XDim3 {u[0],u[1],u[2]};
     }
@@ -444,7 +444,7 @@ struct InjectorMomentumJuttner
         for (auto& el : u) el = 0.0_rt;
         amrex::Real const beta = velocity(x,y,z);
         int const dir = velocity.direction();
-        auto const gamma = static_cast<amrex::Real>(1._rt/sqrt(1._rt-beta*beta));
+        auto const gamma = 1._rt/std::sqrt(1._rt-beta*beta);
         u[dir] = gamma*beta;
         return amrex::XDim3 {u[0],u[1],u[2]};
     }