Read external fields from file in restarted simulation #4547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiLehe
changed the title
RemiLehe
force-pushed
the
fix_external_field_restart
branch
from
3cf26e5 to
b63faf8
Compare
RemiLehe
changed the title
RemiLehe
changed the title
RemiLehe
commented
Jan 5, 2024
RemiLehe
commented
Jan 5, 2024
RemiLehe
commented
Jan 5, 2024
| # Diagnostics | ||
| diagnostics.diags_names = diag1 |
There was a problem hiding this comment.
This test is now a restart test ; as a consequence, the checkpoints need to be saved.
RemiLehe
commented
Jan 5, 2024
| @@ -728,6 +728,9 @@ void | |||
| WarpX::PostRestart () | |||
| { | |||
| mypc->PostRestart(); | |||
There was a problem hiding this comment.
This now loads external fields from file when restarting a simulation
RemiLehe
commented
Jan 5, 2024
| @@ -901,34 +904,7 @@ WarpX::InitLevelData (int lev, Real /*time*/) | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Cleaning up by putting the code below in a separate function.
ax3l
added
bug
ax3l
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When restarting a simulation, the grid external field from file were not read.
As a result, a restarted simulation (e.g. with the electrostatic solver, were the grid external fields are applied at every iteration) would suddenly not feature these fields (without any error or warning message).