Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input of galerkin_scheme #4607

Merged

Conversation

dpgrote
Copy link
Member

@dpgrote dpgrote commented Jan 12, 2024

Move input of galerkin_scheme upward to be before the check of it that is done for the implicit solver.

@dpgrote dpgrote added the component: implicit solvers Anything related to implicit solvers label Jan 12, 2024
Copy link
Member

@lucafedeli88 lucafedeli88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix, @dpgrote

@lucafedeli88 lucafedeli88 merged commit 12a265c into ECP-WarpX:development Jan 15, 2024
41 checks passed
@dpgrote dpgrote deleted the fix_galerkin_scheme_input branch June 14, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: implicit solvers Anything related to implicit solvers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants