Update picmi.ElectrostaticSolver child class in external Poisson solver test
#4622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roelof-groenewald
added
component: electrostatic
dpgrote
approved these changes
Jan 22, 2024
roelof-groenewald
changed the title
picmi.ElectrostaticSolver child class in external Poisson solver testpicmi.ElectrostaticSolver child class in external Poisson solver test
ax3l
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #4554. The external solver tests create child classes of
picmi.ElectrostaticSolver. The overwrite functions forinitialize_inputsshould be updated to besolver_initialize_inputs. This did not break those tests since without the overwrite the standard ES solver was simply used.