Fixing bug in hyper-resistivity calculation which had missing terms i… #5638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n vector laplacian evaluation. Additioanally fixing a staggering bug for density calculation in RZ. Signed-off-by: S. Eric Clark <[email protected]>
Signed-off-by: S. Eric Clark <[email protected]>
There was a problem hiding this comment.
Hmm, the hyper-resistivity term is a vector Laplacian, no? I agree there are bugs here, but it looks like you changed it to a sort-of hybrid scalar / vector Laplacian. Or am I missing something?
For RZ the individual components should be as follows:
But the Cartesian implementation was already correct.
Update: Nevermind. I see this is in fact all wrong. Thanks for catching!
| @@ -633,13 +635,14 @@ void FiniteDifferenceSolver::HybridPICSolveECylindrical ( | |||
| } | |||
|
|
|||
| // Interpolate to get the appropriate charge density in space | |||
| Real rho_val = Interp(rho, nodal, Er_stag, coarsen, i, j, 0, 0); | |||
| Real rho_val = Interp(rho, nodal, Et_stag, coarsen, i, j, 0, 0); | |||
ax3l
added
the
bug: affects latest release
roelof-groenewald
added
the
component: fluid-ohm
|
The fixes look good! Just the one comment above about the |
…k dependencies on flags for standard resistivity. Signed-off-by: S. Eric Clark <[email protected]>
Co-authored-by: Roelof Groenewald <[email protected]>
Signed-off-by: S. Eric Clark <[email protected]>
roelof-groenewald
approved these changes
Feb 4, 2025
Signed-off-by: S. Eric Clark <[email protected]>
auto-merge was automatically disabled
February 4, 2025 19:49
Head branch was pushed to by a user without write access
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: S. Eric Clark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n vector laplacian evaluation. Additioanally fixing a staggering bug for density calculation in RZ.