Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WarpX class : em_solver_medium no longer a static variable #5642

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

lucafedeli88
Copy link
Member

This PR turns the static variable em_solver_medium of the WarpX class into a private non-static member variable : m_em_solver_medium . This is done with the aim of reducing the usage of static variables in WarpX.

@lucafedeli88 lucafedeli88 added the cleaning Clean code, improve readability label Feb 5, 2025
@ax3l ax3l self-requested a review February 11, 2025 00:10
@ax3l ax3l self-assigned this Feb 11, 2025
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ax3l ax3l merged commit 879caec into ECP-WarpX:development Feb 11, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleaning Clean code, improve readability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants