-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Refactor user interface of JRhom algorithm (previously multi-J) #5647
Open
EZoni
wants to merge
12
commits into
ECP-WarpX:development
Choose a base branch
from
EZoni:refactor_multiJ
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65fc740
to
13ead40
Compare
jlvay
approved these changes
Feb 10, 2025
EZoni
commented
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changes input scripts / defaults
Changes the syntax or meaning of input scripts and/or defaults
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement what was discussed during the hackathon and summarized in #5229 (comment).
If accepted, this PR should replace #5229, which addressed only renaming and has many merge conflicts.
The previous input parameters
warpx.do_multi_J
warpx.do_multi_J_n_depositions
psatd.rho_in_time
psatd.J_in_time
are replaced with the one new input parameter
psatd.JRhom
, a string such asCC1
,CL2
, etc., which encodesThis is aligned with the conventions used in the paper where we published the algorithm.
To-do:
psatd.JRhom