Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WarpX class: move out PSATDCurrentCorrection and PSATDVayDeposition #5684

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

lucafedeli88
Copy link
Member

PSATDCurrentCorrection and PSATDVayDeposition are member functions of the WarpX class, but they are used only in WarpXPushFieldsEM.cpp and they can be easily turned into pure functions. Therefore, this PR moves them inside an anonymous namespace in WarpXPushFieldsEM.cpp . The goal is the simplification of the WarpX class.

@lucafedeli88 lucafedeli88 added the cleaning Clean code, improve readability label Feb 19, 2025
@lucafedeli88 lucafedeli88 changed the title WarpX: move PSATDCurrentCorrection and PSATDVayDeposition out of the WarpX class [WIP] WarpX: move PSATDCurrentCorrection and PSATDVayDeposition out of the WarpX class Feb 19, 2025
@lucafedeli88 lucafedeli88 changed the title [WIP] WarpX: move PSATDCurrentCorrection and PSATDVayDeposition out of the WarpX class WarpX: move PSATDCurrentCorrection and PSATDVayDeposition out of the WarpX class Feb 19, 2025
@lucafedeli88 lucafedeli88 changed the title WarpX: move PSATDCurrentCorrection and PSATDVayDeposition out of the WarpX class WarpX class: move out PSATDCurrentCorrection and PSATDVayDeposition Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleaning Clean code, improve readability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant