Refactor Unit Handling for kin_energy #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
before: chrome_mGqIWXmYW2.mp4after (print statement only used in testing): Code_ucXHq6FUm5.mp4 |
|
@cemitch99 Oh, did we want to change this? I liked that it flipped so nicely :) |
|
Ok. The rationale is to keep it simple and consistent, that is ok :) |
ax3l
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the implementation for handling kinetic energy unit changes. While initially intended to address broken functionality introduced in #780, the scope has evolved to implement a more intuitive approach for unit handling that no longer depends on the previous logic.
Previously, changing units would update both the UI display and backend values to represent the same physical quantity (e.g., 5 MeV changed to GeV would result in 0.005 on both the UI and backend). This behavior has now been redesigned to better align with user expectations. With this update, the backend value (in MeV) is updated to reflect the new unit, while the UI number remains constant (e.g., 5 MeV → 5 GeV).